Skip to content

fix object.Equals for EquatableArray #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

fix object.Equals for EquatableArray #1120

merged 1 commit into from
Nov 6, 2025

Conversation

@JamesYFC
Copy link
Contributor

@JamesYFC JamesYFC commented Aug 15, 2025 •
edited
Loading

Closes #1119

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@JamesYFC
Copy link
Contributor Author

JamesYFC commented Aug 15, 2025

@dotnet-policy-service agree

@Sergio0694 Sergio0694 force-pushed the fix/equatable-array-equals branch 2 times, most recently from c90851d to 36e8b3a Compare November 5, 2025 22:00
Sergio0694
Sergio0694 approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙂

@Sergio0694 Sergio0694 force-pushed the fix/equatable-array-equals branch from 36e8b3a to 235bf81 Compare November 6, 2025 04:07
@Sergio0694 Sergio0694 merged commit 95043f5 into CommunityToolkit:main Nov 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sergio0694 Sergio0694 Sergio0694 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

object.Equals() in EquatableArray{T} causes an infinite loop

2 participants

@JamesYFC @Sergio0694